Skip to content

freedreno/a6xx: Fix antichamber trace replay assert

Rob Clark requested to merge robclark/mesa:fd/antichamber-assert into main

What does this MR do and why?

freedreno/a6xx: Fix antichamber trace replay assert

This app is generating viewports with scale[0]==0, so that is not a good condition for testing viewport validity. It would result in skipping the only viewport, and ending up with gb x/y being ~0. Triggering an assert in the register builder.

The main reason this was done previously was to avoid an assert in fd_calc_guardband(). Lets just flip it around and return 0x1ff on errors instead of asserting. This also makes it more consistent with the other error cases.

Closes: #7628 (closed) Signed-off-by: Rob Clark robdclark@chromium.org

Merge request reports