Skip to content

intel/fs: fix dynamic interpolation mode selection

Lionel Landwerlin requested to merge llandwerlin/mesa:review/intel-fs-pixel-interpolator-fix into main

What does this MR do and why?

intel/fs: fix dynamic interpolation mode selection

We can end up in situation where we are dispatched with a multisample framebuffer but not at per-sample. In this case we would request the at_sample value with the wrong message configuration.

Relying on the BRW_WM_MSAA_FLAG_MULTISAMPLE_FBO flag superseeds BRW_WM_MSAA_FLAG_PERSAMPLE_DISPATCH.

Fixes piglit tests :

spec@arb_gpu_shader5@arb_gpu_shader5-interpolateatsample
spec@arb_gpu_shader5@arb_gpu_shader5-interpolateatsample-nonconst

With Zink on Anv

Signed-off-by: Lionel Landwerlin lionel.g.landwerlin@intel.com Fixes: 68027bd3 ("intel/fs: implement dynamic interpolation mode for dynamic persample shaders")

Edited by Lionel Landwerlin

Merge request reports