Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,710
    • Issues 2,710
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 904
    • Merge requests 904
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge requests
  • !2389

aco: refactor value numbering

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Schürmann requested to merge daniel-schuermann/mesa:aco_value_numbering into master Oct 19, 2019
  • Overview 10
  • Commits 1
  • Pipelines 5
  • Changes 1

Previously, we used one hashset per BB, so that we could always initialize the current hashset from the immediate dominator. This patch changes the behavior to a single hashmap using the block index per instruction to resolve dominance.

This patch greatly improves performance of value numbering from roughly 20% of aco's compile time down to < 5% for some average shaders.

  • Code Size: 114455544 -> 114415344 (-0.04 %) bytes

The slight decrease in code size is due removing some restriction.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: aco_value_numbering