Skip to content

zink: fix layout(local_size_variable) for vulkan 1.3+

Julia Tatz requested to merge jdtatz/mesa:zink-local-size-var-fix into main

Use the correct execution mode op, OpExecutionModeId, for LocalSizeId & ensure local_group_size_var is initialized. This fixes 'spec@arb_compute_variable_group_size@local-size' for Vulkan 1.3+

For earlier versions, I'm unsure, but it seems like it was maybe broken as it's been in the flakes files since from before LocalSizeId was even used? I could guard PIPE_COMPUTE_CAP_MAX_VARIABLE_THREADS_PER_BLOCK with vulkan 1.3 and/or maintenance4, and remove the usage of WorkgroupSize if it was already broken

Merge request reports