Skip to content

panfrost/ci: Skip Piglit tests known to crash

Alyssa Rosenzweig requested to merge alyssa/mesa:panfrost/piglit-skip-crash into main

A bunch of Piglits cause crashes, at least when run with PAN_MESA_DEBUG=sync. For many, the crashes are due to faults. Although Piglits are nominally process-isolated, faults can leak across processes to subpar recovery, meaning these crashes are liable to cause robust passing tests to flakes. So, skip any tests known to crash to make sure the coverage is solid.

Given that we run piglit on panfrost in pre-merge CI, but there's nobody actively working on fixing piglits for panfrost, I think this is the best compromise. It means we get to keep the coverage (and ensure we don't regress piglits that are currently passing) but we don't risk flaking CI. Currently deqp-runner is eating massive numbers of piglit flakes. While it's really great that the infrastructure is robust in that way, it'd be better to not have those flakes in CI in the first place (for run time, if not robustness).

If someone starts hacking on Bifrost + desktop OpenGL again for some reason and fixes these tests locally, they can reenable them then.

Signed-off-by: Alyssa Rosenzweig alyssa@rosenzweig.io

Merge request reports