Skip to content

Add some SPIR-V glShaderBinary validation

Jordan Justen requested to merge jljusten/mesa:spirv-shaderbin-validate into main

This fixes the recently added dEQP-GL45-ES3.functional.negative_api.shader.shader_binary OpenGL CTS test. Given we don't have an entry point or the specialization constants for the gl_spirv_validation() call, I'm not sure how thorough the validation is. (No longer calling SPIR-V validation function.)

In the gl-cts, I ran *spir*,*spv* which resulted in 20 passes for 20 tests, and *shader_binary* which was 25 passes, 6 skips and no fails.

@cmarcelo: I saw you did some work in this area. Maybe you can confirm that the changes I made to allow a NULL entry point name seem safe. (No longer calling SPIR-V validation function.)

Cc: @tpalli, @pixelcluster

Edited by Jordan Justen

Merge request reports