Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,689
    • Issues 2,689
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 902
    • Merge requests 902
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge requests
  • !23

nir: properly find the entry to keep in copy_prop_vars

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Caio Oliveira requested to merge cmarcelo/mesa:bug108624 into master Dec 17, 2018
  • Overview 1
  • Commits 1
  • Changes 1

When copy propagation handles a store/copy, it iterates the current copy entries to remove aliases, but keeps the "equal" entry (if exists) to be updated.

The removal step may swap the entries around (to ensure there are no holes), invalidating previous iteration pointers. The bug was saving such pointer to use later. Change the code to first perform the removals and then find the remaining right entry.

This was causing updates to be lost since they were being made to an entry that was not part of the current copies.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108624 Fixes: b3c61469 "nir: Copy propagation between blocks" Cc: mesa-stable@lists.freedesktop.org

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bug108624