Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !21891

panfrost: Fix Piglit issues that may cause flakes

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Alyssa Rosenzweig requested to merge alyssa/mesa:panfrost/deflake into main Mar 14, 2023
  • Overview 12
  • Commits 11
  • Pipelines 9
  • Changes 17

We just re-enabled the piglit G52 job. I'm not sure if this is a good idea, but at any rate, it's there and needs to be flake-free. This gets us closer to that goal. From what I can tell, there are no piglit-runner level flakes in the job due to the classic sources of flakiness (race conditions, memory snafu, etc). Instead, our Piglit test flakes seem to be the result of running multiple piglit processes in parallel via piglit-runner, with faults in one process sometimes affecting concurrent rendering in another. While this isn't great from a robustness standpoint, there isn't much we can do about in Mesa, other than make sure we don't fault in Piglit. Given this theory, this series fixes a number of GPU faults triggered in piglit on Mali-G52. On a local run, this seems to decrease the piglit-runner reported flake count from 3 to 2, which is a win!

In the CI setting, the pipeline that ran for this has 7 flakes in the piglit job, compared to 12-14 on the piglit jobs of recent commits merged to main. Not super scientific but looks like conservatively a ~30% reduction in piglit-runner level flakes for the job.

Edited Mar 14, 2023 by Alyssa Rosenzweig
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: panfrost/deflake