Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !21774

intel/compiler: Use nir SUBGROUP_INVOCATION for RT TOPOLOGY_ID

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Jordan Justen requested to merge jljusten/mesa:rt-channel-num into main Mar 07, 2023
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 1

This seems simpler, and made the sim happy (albeit in a case that doesn't impact Mesa today).

As a tangent, the sim was also happy with the codegen after:

-            ubld8.ADD(quarter(tmp, 1), quarter(tmp, 0), brw_imm_ud(8));
+            ubld8.ADD(quarter(tmp, 1), quarter(tmp, 0), brw_imm_uw(8));

This more closely matches the code from 8f48d23e, which after 6132992c is used to build SYSTEM_VALUE_SUBGROUP_INVOCATION.

Tested in ci: https://mesa-ci.01.org/jljusten/builds/371/group/63a9f0ea7bb98050796b649e85481845

Cc: @llandwerlin, @gfxstrand

Edited Mar 07, 2023 by Jordan Justen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rt-channel-num