Skip to content

agx: Fix 2D MSAA array texture register allocation

Alyssa Rosenzweig requested to merge alyssa/mesa:agx/msaa-array-ra into main

Sample index and layer index are both 16-bits, even though they are zero extended for compiler simplicity in some cases. In particular this means that 2D MSAA arrays consume 6 half-regs for their coordinates, not 8. This is what the IR translation (actually agx_nir_lower_texture) produces, we just need to fix the calculation in agx_read_registers to agree.

Fixes validation failure in tests like dEQP-GLES31.functional.texture.multisample.samples_4.use_texture_color_2d_array

Signed-off-by: Alyssa Rosenzweig alyssa@rosenzweig.io

Merge request reports