Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,085
    • Issues 3,085
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,018
    • Merge requests 1,018
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • MesaMesa
  • mesamesa
  • Merge requests
  • !2156

lima: do not set the PP uniforms address lowest bits

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Icenowy Zheng requested to merge icenowy/mesa:lima-uniforms-address-size into master Sep 27, 2019
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1

The PP uniforms address register in render state is not a direct pointer to the uniforms storage -- instead, it points to an one-item array, and the array item is the real pointer to the uniforms storage.

This register reuses some of its LSBs as a size field. Currently the size is set according to the length of the real uniforms storage. However, as the register itself contains only a pointer to the one-item array, the size field should be set to the length of the one-item array and subtract it by 1, which means a fixed value of 0. That means we can just omit it now.

Test shows this should be the correct approach to set this register.

Signed-off-by: Icenowy Zheng icenowy@aosc.io

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: lima-uniforms-address-size