Skip to content

i965/fs: add a comment about how the rounding mode in fmul is set

Andres Gomez requested to merge tanty/mesa:comment-fmul into master

After 1711bf6c ("intel/fs: Generate better code for fsign multiplied by a value"), the conflicts resolution for setting the rounding mode after the fused fmul and fsign optimization is non obvious.

Basically, the optimization doesn't really result in a MUL, or any other operation which would need to have the rounding mode set. Hence, we set it just before the actual MUL in the treatment of fmul.

Fixes: ba1e25e1 ("i965/fs: set rounding mode when emitting fadd, fmul and ffma instructions") Suggested-by: Caio Marcelo de Oliveira Filho caio.oliveira@intel.com Signed-off-by: Andres Gomez agomez@igalia.com

Merge request reports