Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,059
    • Issues 3,059
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,001
    • Merge requests 1,001
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !2060

radeonsi/nir: lower load constants to scalar

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timothy Arceri requested to merge tarceri/mesa:si_lower_constants into master Sep 20, 2019
  • Overview 3
  • Commits 1
  • Pipelines 3
  • Changes 1

We call nir_lower_load_const_to_scalar in the state trackers linker however some later passes can reintroduce constant vectors. Here we lower these to scalar and perform optimisations. The Intel drivers do a similiar call in their backend..

shader-db results VEGA 64:

 Totals from affected shaders:
 SGPRS: 152168 -> 151976 (-0.13 %)
 VGPRS: 135224 -> 135112 (-0.08 %)
 Spilled SGPRs: 4027 -> 4163 (3.38 %)
 Spilled VGPRs: 0 -> 0 (0.00 %)
 Private memory VGPRs: 0 -> 0 (0.00 %)
 Scratch size: 0 -> 0 (0.00 %) dwords per thread
 Code Size: 10670028 -> 10654776 (-0.14 %) bytes
 LDS: 0 -> 0 (0.00 %) blocks
 Max Waves: 13122 -> 13135 (0.10 %)
 Wait states: 0 -> 0 (0.00 %)
Edited Sep 20, 2019 by Timothy Arceri
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: si_lower_constants