Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,047
    • Issues 3,047
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 990
    • Merge requests 990
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !20396

ir3: Do 16b tex dst folding only for floats

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Danylo Piliaiev requested to merge Danil/mesa:ir3/fix/16b-int-dst-tex-folding into main Dec 20, 2022
  • Overview 5
  • Commits 2
  • Pipelines 7
  • Changes 6

Folding signed or unsigned i32 -> i16 conversion into sampling instruction causes it to behave differently with out-of-bounds values. The conversion expects higher bits being masked, however folded variant does clamp the value.

A concrete example is that:

 isaml.base0 (u16)(x)hr0.x

is not equal this:

 isaml.base0 (u32)(x)r0.w
 (sy)cov.u32u16 hr0.x, r0.w

Fixes misrendering in "Injustice 2".

Closes: #7869 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ir3/fix/16b-int-dst-tex-folding