Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,047
    • Issues 3,047
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 990
    • Merge requests 990
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !20099

nir/nir_opt_offsets: Prevent offsets going above max

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Danylo Piliaiev requested to merge Danil/mesa:nir/fix/nir_opt_offsets-shared-mem-offset-limit into main Dec 01, 2022
  • Overview 5
  • Commits 1
  • Pipelines 9
  • Changes 1

In try_fold_load_store when trying to extract const addition from non-const offset source, we should take into account that there is already a constant base offset, which should count towards the limit.

The issue was found in "Monster Hunter: World" running on Turnip.

Fixes: cac6f633 ("nir/opt_offsets: Use nir_ssa_scalar to chase offset additions.")

Well, the issue was present before this commit but it made a lot of changes in surrounding code.


It seems only Turnip has non-~0 limit for shared_max, so only Turnip was affected by this issue in the wild.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nir/fix/nir_opt_offsets-shared-mem-offset-limit