Skip to content

v3dv: barebone support for YCbCr conversion

Alejandro Piñeiro requested to merge apinheiro/mesa:wip/apinheiro/v3dv-barebone-ycbcr into main

This is the "barebone" version of MR !17785 (closed), originally created by @Ella-0. As I'm here, I just want to thank and give kudos to @Ella-0 for that awesome work.

!17785 (closed) was trying to implement and provide support to as many as possible ycbcr features and formats. So the remaining list of ycbcr tests failing, and out-of-ycbcr regressions, was somewhat long. The purpose of this MR is to focus on the mandatory features and formats of the extension. Also, with a smaller scope, I hope review would be easier.

I preferred to create a new MR and branch so we could have a copy of the original (and with more features) code, as reference. Also because it felt strange to me to force push on a branch and MR from a different developer.

Some notes:

  • This MR also includes the rebased patches from !9952 (closed). As part of this work I reviewed/ack-ed all those.
  • As I modified several patches which original author was @Ella-0 I did the same that we did on the past when more that one igalian modified a patch: I kept @Ella-0 as the original author, and added two Signed-off at the end (@Ella-0 and myself). I also listed the changes compared with the original patch.
  • I tried to keep those changes to remove code, and trivial fixes. For any change that needed some code I wrote separate patches.
  • Having said so, if I were the original author of those patches I would have just squashed them. So one possibility is to do that.
  • There is one exception to the "just the mandatory features", with the patch "v3dv/format: restore DISJOINT and MIDPOINT_CHROMA_SAMPLES". I think that we can keep it here, but just in case, it is initially on a separate patch.

Merge request reports