Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,069
    • Issues 3,069
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,005
    • Merge requests 1,005
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !1924

Fix gallium's fake-GLX's MakeCurrent(dpy, None, None, ctx)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Adam Jackson requested to merge ajax/mesa:gallium-xlib-glx into master Sep 10, 2019
  • Overview 9
  • Commits 3
  • Pipelines 2
  • Changes 2

We have two - two! - fake xlib-backed GLX implementations. The classic one uses classic swrast, the gallium one uses softpipe or llvmpipe. As a result the gallium one is almost uniformly superior, and this is one more consumer of classic swrast that we can hopefully get rid of. But I say "almost" for a reason, there are a few piglit regressions in gallium relative to classic.

This MR addresses piglit's glx-create-context-current-no-framebuffer test. classic escapes with a warning here because swrast maxes out at GL 2.1, and the test (and functionality) requires GL 3.0 or better.

The other failures are in actual rendering interactions, specifically glx-copy-sub-buffer, glx-multi-context-single-window and glx-tfp. For the last one I think the test is probably broken (see piglit#21), for the other two I suspect y-inversion shenanigans.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gallium-xlib-glx