Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,069
    • Issues 3,069
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,005
    • Merge requests 1,005
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !1917

st/nine: Ignore D3DSIO_RET if it is the last instruction in a shader

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Danylo Piliaiev requested to merge GL/mesa:fix/tgsi-to-nir-ignore-ret into master Sep 10, 2019
  • Overview 29
  • Commits 1
  • Pipelines 7
  • Changes 1

RET as a last instruction could be safely ignored. Remove it to prevent crashes/warnings in case underlying driver doesn't implement arbitrary returns.

A better way would be to remove the RET after the whole shader is parsed which will handle a possible case when the last RET is followed by a comment.

This would fix crash in Lunatic Rave 2 which has ret at the end of one vertex shader. Apitrace of the game could be found at https://github.com/Joshua-Ashton/d9vk/issues/192

Edited Sep 24, 2019 by Danylo Piliaiev
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/tgsi-to-nir-ignore-ret