Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,076
    • Issues 3,076
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,007
    • Merge requests 1,007
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • MesaMesa
  • mesamesa
  • Merge requests
  • !18174

radeonsi: fix tcs_out_lds_offsets arg alignment

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Qiang Yu requested to merge yuq825/mesa:topic/fix-tcs-offset into main Aug 22, 2022
  • Overview 4
  • Commits 1
  • Pipelines 5
  • Changes 3

tcs_out_lds_offsets is not sure to be 16 byte aligned, it's calculated like this:

num_patches * patch_vertices * lshs_vertex_stride

num_patches and patch_vertices are not sure to be any value aligned, lshs_vertex_stride is added one extra dword, so it's only 4 byte aligned.

This may cause problem even before we switch to nir tess output lower when write tess factor before read tail of input. But it's more likely to cause problem after we switch to nir tess output lower because the main body won't eliminate the low 4bit offset but epilog will, so they use different offset to read/write tess factor.

Fixes: 7598bfd7 ("radeonsi: replace llvm tcs output with nir lower pass") Closes: #7083 (closed) Signed-off-by: Qiang Yu yuq825@gmail.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: topic/fix-tcs-offset