Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,031
    • Issues 3,031
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 997
    • Merge requests 997
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !18054

nir/zink: Don't Optimize AND'd shift bit count if not supported

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Soroush Faghihi requested to merge Soroush/mesa:zink-fix-fp64-ceil into main Aug 15, 2022
  • Overview 12
  • Commits 1
  • Pipelines 5
  • Changes 3

Spir-v specifies shifts by values more than bit width to be undefined. This means removing the AND by (bitwidth-1) is invalid for zink. This opt produced ishl by constant (-1) when using soft fp64. This caused failures in a bunch of cts cases involving fp64 with softfp64 like: KHR-GL46.gpu_shader_fp64.builtin.ceil_double.

Cc: mesa-stable

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: zink-fix-fp64-ceil