ir3: fix const alloc for tesselation and cl (!17570) · Merge requests · Mesa / mesa

Chia-I Wu requested to merge olv/mesa:tu-tess-param into main Jul 15, 2022

primitive_param takes up 2 vec4's. Remove an align that I don't understand. I am marking this RFC because of this.

The align upset

Test case 'dEQP-VK.subgroups.ballot_broadcast.graphics.subgroupbroadcast_vec4'..
deqp-vk: ../src/freedreno/ir3/ir3_nir.c:1039: void ir3_setup_const_state(nir_shader *, struct ir3_shader_variant *, struct ir3_const_state *): Assertion `constoff <= ir3_max_const(v)' failed.

with an older version (android11-tests-dev branch) of deqp-vk. This is because ir3_nir_opt_preamble uses the function for the worst case but the function fails to replace the align by the worst case.

No regression with dEQP-VK.*tess*.

Edited Jul 23, 2022 by Chia-I Wu

ir3: fix const alloc for tesselation and cl

Merge request reports