Skip to content

venus: use linear modifier for legacy common wsi path

Yiwei Zhang requested to merge zzyiwei/mesa:legacy-wsi into main

WSI images and Android AHBs can have tiling modifier overrides, thus we must override the aspectMask upon image subresource layout query.

Towards the renderer, venus better uses VK_EXT_image_drm_format_modifier to force linear with tiling modifier and mod_linear. Doing so won't make any difference on the mesa implementations we care about given we have required VK_EXT_image_drm_format_modifier for wsi support, while common wsi has already brutely assumes dma_buf export support for the legacy scanout flag.

A lucky side effect of this is to allow common wsi to work with host implementations not supporting dma_buf export.

TEST: vkcube on venus in crostini on turnip, anv, radv and mali-bifrost-ddk-r32p0

Edited by Yiwei Zhang

Merge request reports