Skip to content

util/vbuf: fix buffer translation sizing

Mike Blumenkrantz requested to merge zmike/mesa:vbuf_stop_im_still_on_vacation_you_cant_do_this_to_me into main

the original change here attempted to fix calculating the maximum bound for the mapped readback buffer by adding the maximum attribute size to the final element used by readback

the calculation was erroneous, however, because it instead calculated the maximum offset instead of the size, which would cause a different kind of overrun

Fixes: 3c5b7dca ("util/vbuf: fix buffer overrun in attribute conversions")

fixes #5846 (closed)

Edited by Mike Blumenkrantz

Merge request reports