Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,778
    • Issues 2,778
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 950
    • Merge requests 950
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge requests
  • !14371

pan/bi: Fix load_const of 1-bit booleans

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alyssa Rosenzweig requested to merge alyssa/mesa:webrender into main Jan 02, 2022
  • Overview 2
  • Commits 1
  • Pipelines 7
  • Changes 2

For historical reasons, we ingest 1-bit booleans in NIR but expand them to 16/32-bit booleans in the backend IR. We need to handle this case when loading boolean constants, extending from 1-bit to 16/32-bit as required. This issue is masked by effective constant folding for booleans, but is visible in a shader from Firefox WebRender.

Signed-off-by: Alyssa Rosenzweig alyssa@collabora.com Reported-by: Icecream95 Cc: mesa-stable Closes: #5797 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: webrender