Skip to content

RFC: mesa: Remove OptimizeForAOS and associated GLSL code.

Emma Anholt requested to merge anholt/mesa:mvp-dp4 into main

Now that classic is gone, this code is dead. Do we want to revive it for crocus?

    mesa: Remove OptimizeForAOS and associated GLSL code.
    
    Nobody sets it since we retired r100/r200/i965.
    
    crocus could want this, actually, since i965 set it.  It's a loss of this
    shader-db opportunity:
    
    total instructions in shared programs: 7970480 -> 7960995 (-0.12%)
    instructions in affected programs: 174076 -> 164591 (-5.45%)
    
    For softpipe (and probably r300 and nv30), setting this despite being AOS
    ends up being a loss because DPH was retired from TGSI a while back, so
    you miss the opportunities for this algebraic transform to get rid of the
    vector setup:
    
    (('fdot4', ('vec4', a, b,   c,   1.0), d), ('fdph',  ('vec3', a, b, c), d), '!options->lower_fdph'),

Merge request reports