Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,881
    • Issues 2,881
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 908
    • Merge requests 908
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge requests
  • !13963

Open
Created Nov 26, 2021 by Vasily Khoruzhick@anarsoulDeveloper
  • Report abuse
Report abuse

Draft: lima: wire up MSAA 4x support

  • Overview 7
  • Commits 4
  • Pipelines 6
  • Changes 18

Utgard supports MSAA 4x, so wire it up.

RSW bits were already REd by Luc, the only missing part was MSAA for depth/stencil buffer, and it turns out that MSAA 4x isn't actually free if you need to store depth or stencil buffers. In this case it requires 4x buffer size, and for reload it's necessary to reload each sample individually, so it's 4x memory bandwidth for depth/stencil reload with MSAA 4x

As a side fix, it turns out that our wb_reg definition wasn't correct, 'zero' isn't always zero, it's set if we need to swap channels, and it goes before mrt_bits. mrt_bits actually enables multiple MRTs - blob sets it to 0xf for depth/stencil reload with MSAA enabled, and mrt_pitch is set to mrt_pitch (in bytes), so rename zero to flags and change its order.

Fixes dEQP-GLES2.functional.multisample.*

Edited Nov 27, 2021 by Vasily Khoruzhick
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: lima-msaa