Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,071
    • Issues 3,071
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,004
    • Merge requests 1,004
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • MesaMesa
  • mesamesa
  • Merge requests
  • !13955

nir/split_vars: fix incorrect assert

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Lionel Landwerlin requested to merge llandwerlin/mesa:review/nir-split-var-incorrect-assert into main Nov 25, 2021
  • Overview 5
  • Commits 1
  • Pipelines 2
  • Changes 1

In CL in particular this assert might not hold.

Indeed because of previous passes like nir_lower_vars_to_explicit_types() which which will call glsl_get_cl_type_size_align() the bare type of a variable vec4[3] will be turned into vec4x0a16B[3] which will now have a different bare type than variable.

Signed-off-by: Lionel Landwerlin lionel.g.landwerlin@intel.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: review/nir-split-var-incorrect-assert