Skip to content

radv: Remove the skipping of framebuffer emission if we don't have a framebuffer.

Bas Nieuwenhuizen requested to merge bnieuwenhuizen/mesa:inherit into main

This was plain broken. The solution is to not require any framebuffer changes. Silently skipping results in broken behavior. e.g:

(secondary cmdbuffer with no framebuffer) ClearAttachment 2

translated into

bind attachment 2 as attachment 0 (skipped) clear attachment 0 restore original bindings (skipped)

which results in clearing attachment 0, not what we wanted. It is a small wonder CTS doesn't find it until VK_KHR_dynamic_rendering.

Closes: #862 (closed)

Merge request reports