Skip to content

RFC: anv: fix VK_DYNAMIC_STATE_COLOR_WRITE_ENABLE_EXT state

Lionel Landwerlin requested to merge llandwerlin/mesa:review/anv-rt-write-disable-fix into main

There is a problem if you do the following

 vkCmdSetColorWriteEnableEXT(attachmentCount = 8)
 vkCmdBindPipeline(GFX, with attachmentCount = 4)
 vkCmdDraw()
 vkCmdBindPipeline(GFX, with attachmentCount = 8)
 vkCmdDraw()

Because in the dynamic state emission code we rely on the first pipeline to figure the number of BLEND_STATE entries to prepare. This is wrong, we should fill all entries so that the dynamic state works regardless of the number of attachments in the pipeline.

Fixes: b15bfe92 ("anv: implement VK_EXT_color_write_enable") Signed-off-by: Lionel Landwerlin lionel.g.landwerlin@intel.com

Edited by Lionel Landwerlin

Merge request reports