Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,067
    • Issues 3,067
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1,000
    • Merge requests 1,000
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !12858

nir: crocus: iris: Implement finalize_nir callback

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ian Romanick requested to merge idr/mesa:review/iris-finalize_nir into main Sep 14, 2021
  • Overview 8
  • Commits 6
  • Pipelines 9
  • Changes 11

This MR includes a couple small changes to NIR and crocus as part of the initial clean up / refactoring.

Improves performance of SynMark OglDrvShComp by +241.879%±1.01366% (n=5) on a random KBL desktop that I have. That seems to put it at about the same performance as i965, but I did not test that in a statistically sound way.

@kwg had a similar commit about a year ago (kwg/mesa@35d0a59c). In that commit message he said:

Improves performance in SynMark OglDrvShComp (a compiler microbenchmark) by 2.1x on my i7-7700HQ. This is still much slower than i965, though.

I'm not sure if that "2.1x" mean +210% or +110%. My result seems different in that the delta with i965 seems pretty small now. I was using a i7-7700K, so the CPUs were pretty similar. Both are Kaby Lake, but mine is a much higher clocked desktop part.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: review/iris-finalize_nir