Skip to content

nir: Fix lowering of bitfield_insert to shifts.

Emma Anholt requested to merge anholt/mesa:nir-bitfieldinsert-fix into master

The bfi/bfm behavior change replaced the bfi/bfm usage in lower_bitfield_insert_to_shifts with actual shifts like the name says, but it failed to handle the offset=0, bits==32 case in the new lowering.

Fixes regressions in dEQP-GLES31.bitfield_insert on freedreno.

Fixes: 165b7f3a ("nir: define behavior of nir_op_bfm and nir_op_u/ibfe according to SM5 spec.")

Merge request reports