Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !1165

i965: Move resources lowering after NIR linking

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Caio Oliveira requested to merge cmarcelo/mesa:r/post-linker-passes into master Jun 22, 2019
  • Overview 4
  • Commits 1
  • Pipelines 6
  • Changes 3

Those either depend on information filled by the NIR linking steps OR are restricted by those:

  • gl_nir_lower_samplers: depends on UniformStorage being set by the linker.

  • brw_nir_lower_image_load_store: After 6981069f "i965: Ignore uniform storage for samplers or images, use binding info" we want this pass to happen after gl_nir_lower_samplers.

  • gl_nir_lower_buffers: depends on UniformBlocks and SharedStorageBlocks being set by the linker.

For the regular GLSL code path, those datastructures are filled earlier. For NIR linking code path we need to generate the nir_shader first then process it -- and currently the processing works with all shaders together. So move the passes out of brw_create_nir into its own function, called by the brwProgramStringNotify and brw_link_shader().

This patch prepares ground for ARB_gl_spirv, that will make use of NIR linker.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: r/post-linker-passes