iris: Misrendering on some websites (text overlapping)
On https://www.bestbuy.com/site/insignia-43-class-f30-series-led-4k-uhd-smart-fire-tv/6448758.p?skuId=6448758 — some of the text in the "More to consider" section misrenders. See this screenshot:
We've found that this patch works around the issue:
diff --git a/src/gallium/drivers/iris/iris_state.c b/src/gallium/drivers/iris/iris_state.c
index 748bea90986..e4c33c286e6 100644
--- a/src/gallium/drivers/iris/iris_state.c
+++ b/src/gallium/drivers/iris/iris_state.c
@@ -6432,6 +6432,8 @@ iris_upload_dirty_render_state(struct iris_context *ice,
// XXX: does this need to happen at 3DSTATE_BTP_PS time?
iris_emit_pipe_control_flush(batch, "workaround: RT BTI change [draw]",
PIPE_CONTROL_RENDER_TARGET_FLUSH |
+ PIPE_CONTROL_TILE_CACHE_FLUSH |
+ PIPE_CONTROL_STATE_CACHE_INVALIDATE |
PIPE_CONTROL_STALL_AT_SCOREBOARD);
}
which is the same work around ChromeOS applied to resolve #7272 (closed). We dropped that patch when we uprev'd from Mesa 22.1.4 to 22.3.0 because we believed that commit 34699426 resolved all of the misrendering, but evidently we were incorrect.