d3d12: Fix shader variant selection linkages (Follow-up from "CI/Windows: Restore CI and update baselines")
The following discussion from !16756 (merged) should be addressed:
-
@jenatali started a discussion: These crashes are due to a long-standing bug in how shader variants are selected, combined with my fix for polygon stipple, causing a crash in a blit shader. When the VS variant is selected, the PS variant has
POSITION
marked as used (because stipple needs it), but when the PS variant is selected later, it doesn't usePOSITION
. Inverting the order fixes some tests but breaks others... so we probably need to do some kind of 2-pass thing, where linkages are done after some part of the variant key is filled out.