[anv][bisected][regression][hsw]
The following tests began to crash after mesa=0513ff65 (maybe we want to put these on the black/denylist?):
Author: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Date: Mon Jan 24 11:49:19 2022 +0200
anv: verify that the format supports multisampling
We tightened the requirements for multisampling on Gfx7 but didn't
format that at the Vulkan level.
This will break more conformance tests on Gfx7, but we weren't
conformant anyway.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 531b1b7511af ("intel/isl: Strengthen MCS SINT format restriction")
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14679>
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index abaa6a465408..1bf601829678 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/src/intel/vulkan/anv_formats.c
@@ -1108,7 +1108,8 @@ anv_get_image_format_properties(
(format_feature_flags & (VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BIT_KHR |
VK_FORMAT_FEATURE_2_DEPTH_STENCIL_ATTACHMENT_BIT_KHR)) &&
!(info->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) &&
- !(info->usage & VK_IMAGE_USAGE_STORAGE_BIT)) {
+ !(info->usage & VK_IMAGE_USAGE_STORAGE_BIT) &&
+ isl_format_supports_multisampling(devinfo, format->planes[0].isl_format)) {
sampleCounts = isl_device_get_sample_counts(&physical_device->isl_dev);
}
dEQP-VK.robustness.image_robustness.bind.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.bind.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.bind.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.push.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.push.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.push.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.push.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.push.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.push.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.push.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.push.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.push.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.push.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.push.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.push.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.push.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.push.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.push.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.push.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.push.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.push.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.push.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.push.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.image_robustness.push.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.image_robustness.push.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.image_robustness.push.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.image_robustness.push.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.bind.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.bind.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.bind.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.bind.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.bind.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.bind.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.bind.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.bind.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.bind.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.bind.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.bind.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.bind.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.bind.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.bind.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.bind.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.bind.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.bind.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.bind.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.bind.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.bind.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.bind.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.bind.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.bind.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.bind.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.push.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.push.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.push.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.push.notemplate.r32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.push.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.push.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.push.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.push.notemplate.r32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.push.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.push.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.push.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.push.notemplate.rg32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.push.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.push.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.push.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.push.notemplate.rg32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.push.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.push.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.push.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.push.notemplate.rgba32i.dontunroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
dEQP-VK.robustness.robustness2.push.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.comp
dEQP-VK.robustness.robustness2.push.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d.frag
dEQP-VK.robustness.robustness2.push.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.comp
dEQP-VK.robustness.robustness2.push.notemplate.rgba32i.unroll.nonvolatile.sampled_image.no_fmt_qual.img.samples_4.2d_array.frag
Multiple tests were getting this error message in stdout (from https://mesa-ci.01.org/vulkancts/builds/23882/results/12716613564):
vk.createImage(device, pCreateInfo, pAllocator, &object): VK_ERROR_OUT_OF_DEVICE_MEMORY at vkRefUtilImpl.inl:267
This causes the test to crash.