intel: State cache invalidation after BLORP binding table setup ought to be unnecessary on ICL.
BLORP performs an invalidation of the state cache from blorp_setup_binding_table()
, arguably to make sure that any update of the clear color value becomes visible, however on ICL+ the clear color is no longer stored in the surface state structure, so it seems like this invalidation ought to be unnecessary. Commit a748b264 dropped the redundant invalidation on TGL+ with a measurable performance improvement. However the same change would lead to some crucible regressions when applied to ICL for unknown reasons -- It's possible that the ICL-specific clear color update path based on MI_ATOMIC isn't correctly ordered with the pre-existing invalidation in blorp_update_clear_color()
. Investigate the reason for that in more detail.