llvmpipe: cs shader cache keys using stack garbage?
valrgind on KHR-GL45.shader_atomic_counter_ops_tests.ShaderAtomicCounterOpsExchangeTestCase
:
==2521323== Use of uninitialised value of size 8
==2521323== at 0x6072D32: _mesa_sha1_format (mesa-sha1.c:47)
==2521323== by 0x606E8CA: disk_cache_get_cache_filename (disk_cache_os.c:587)
==2521323== by 0x606DB2C: disk_cache_get (disk_cache.c:441)
==2521323== by 0x6787635: lp_disk_cache_find_shader (lp_screen.c:923)
==2521323== by 0x67B27FA: generate_variant (lp_state_cs.c:740)
==2521323== by 0x67B27FA: llvmpipe_update_cs (lp_state_cs.c:862)
==2521323== by 0x67B5157: llvmpipe_cs_update_derived (lp_state_cs.c:1269)
==2521323== by 0x67B5157: llvmpipe_launch_grid (lp_state_cs.c:1345)
==2521323== by 0x60F0632: st_dispatch_compute_common (st_cb_compute.c:71)
==2521323== by 0x6174A51: dispatch_compute (compute.c:300)
==2521323== by 0x6174A51: _mesa_DispatchCompute (compute.c:318)
==2521323== by 0x7A9AF2: gl4cts::ShaderAtomicCounterOpsTestBase::ShaderPipeline::executeComputeShader(deqp::Context&) (gl4cShaderAtomicCounterOpsTests.cpp:302)
==2521323== by 0x7AA484: gl4cts::ShaderAtomicCounterOpsTestBase::ShaderPipeline::test(deqp::Context&) (gl4cShaderAtomicCounterOpsTests.cpp:249)
==2521323== by 0x7AA76E: gl4cts::ShaderAtomicCounterOpsTestBase::iterate() (gl4cShaderAtomicCounterOpsTests.cpp:598)
==2521323== by 0x632B1E: gl3cts::TestCaseWrapper::iterate(tcu::TestCase*) (gl3cTestPackages.cpp:114)
==2521323== Uninitialised value was created by a stack allocation
==2521323== at 0x67B2364: llvmpipe_update_cs (lp_state_cs.c:787)
Not seen with dEQP-GLES31.functional.shaders.builtin_functions.precision.sign.highp_compute.scalar
or dEQP-GLES31.functional.compute.basic.atomic_counter_multiple_groups