BUG: After issues playing World of Warcraft with RADV
AMD Radeon Vulkan (RADV) issue template
Playing World of Warcraft with DXVK and RADV from latest Mesa + patch to fix problem with FPS:
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
index dcad48ca612..124377dd6cb 100644
--- a/src/vulkan/wsi/wsi_common_x11.c
+++ b/src/vulkan/wsi/wsi_common_x11.c
@@ -236,9 +236,9 @@ wsi_x11_connection_create(struct wsi_device *wsi_dev,
#endif
if (randr_reply && randr_reply->present != 0)
- {
wsi_conn->is_xwayland = wsi_x11_detect_xwayland(conn);
- }
+ else
+ wsi_conn->is_xwayland = false;
wsi_conn->has_dri3_modifiers = has_dri3_v1_2 && has_present_v1_2;
wsi_conn->is_proprietary_x11 = false;
@@ -249,6 +249,7 @@ wsi_x11_connection_create(struct wsi_device *wsi_dev,
free(dri3_reply);
free(pres_reply);
+ free(randr_reply);
free(amd_reply);
free(nv_reply);
@@ -1060,7 +1061,7 @@ x11_present_to_x11_dri3(struct x11_swapchain *chain, uint32_t image_index,
int64_t remainder = 0;
struct wsi_x11_connection *wsi_conn =
- wsi_x11_connection_create((struct wsi_device*)chain->base.wsi, chain->conn);
+ wsi_x11_get_connection((struct wsi_device*)chain->base.wsi, chain->conn);
if (!wsi_conn)
return VK_ERROR_OUT_OF_HOST_MEMORY;
My problem is that some ghostly artifacts from previous screens are not being erased.
I am using these Wine RPMs from Fedora 33:
- wine-6.0-0.5rc5.fc33.x86_64
- wine-dxvk-1.7.2-3.fc33.x86_64
This is the relevant part of the glxinfo
output:
Extended renderer info (GLX_MESA_query_renderer):
Vendor: AMD (0x1002)
Device: AMD Radeon (TM) R7 300 Series (BONAIRE, DRM 3.40.0, 5.10.6, LLVM 12.0.0) (0x665f)
Version: 21.0.0
Accelerated: yes
Video memory: 2048MB
Unified memory: no
Preferred profile: core (0x1)
Max core profile version: 4.6
Max compat profile version: 4.6
Max GLES1 profile version: 1.1
Max GLES[23] profile version: 3.2
Memory info (GL_ATI_meminfo):
VBO free memory - total: 1422 MB, largest block: 1422 MB
VBO free aux. memory - total: 2777 MB, largest block: 2777 MB
Texture free memory - total: 1422 MB, largest block: 1422 MB
Texture free aux. memory - total: 2777 MB, largest block: 2777 MB
Renderbuffer free memory - total: 1422 MB, largest block: 1422 MB
Renderbuffer free aux. memory - total: 2777 MB, largest block: 2777 MB
Memory info (GL_NVX_gpu_memory_info):
Dedicated video memory: 2048 MB
Total available memory: 5120 MB
Currently available dedicated video memory: 1422 MB
OpenGL vendor string: AMD
OpenGL renderer string: AMD Radeon (TM) R7 300 Series (BONAIRE, DRM 3.40.0, 5.10.6, LLVM 12.0.0)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 21.0.0-devel (git-00064713a3)
A git bisect
has identified this commit:
6e7008e94baf242a8e0db3b4209a4d2acbf9376d is the first bad commit
commit 6e7008e94baf242a8e0db3b4209a4d2acbf9376d
Author: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Date: Tue Jan 5 14:28:53 2021 +0100
radv: do not predicate FMASK decompression when DCC+MSAA is used
Even if the FCE predicate is FALSE, we might still need to decompress
FMASK if compressed rendering was used. FMASK decompressions should
never been predicated.
This fixes a ton of CTS failures and a rendering issue with Control
when DCC+MSAA is force-enabled.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8331>
src/amd/vulkan/radv_meta_fast_clear.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)