[bisected] Compton weird colors

Submitted by Christoph Haag

Assigned to Default DRI bug account

Link to original bug (#104597)

Description

Created attachment 136675 Desktop with compton --backend glx

RX 480, mesa master.

Running compton --backend glx produces the effect in the attached image. The colors are corrupted, but some applications look correct.

There is one situation where I have seen a similar effect not involving compton and that is kwin's window preview of SteamVR's vrmonitor: https://www.youtube.com/watch?v=IHHQS_Q5uqE. All other window previews work correctly, it's only the vrmonitor that's broken. But that's enough to say it's not a compton specific problem.

Attachment 136675, "Desktop with compton --backend glx":

Version: git

added bugzilla radeonsi labels

Michel Dänzer @daenzer said:

It could be similar bugs in compton and kwin. :)

If this started recently, maybe you can try bisecting Mesa.

I wonder if this might be related to bug 104599.

Christoph Haag said:

e5ff036c is the first bad commit commit e5ff036c Author: Mario Kleiner mario.kleiner.de@gmail.com Date: Fri Dec 15 23:05:07 2017 +0100

st/dri: Add support for BGR[A/X]1010102 formats.

Exposes RGBA 10 10 10 2 and 10 10 10 0 visuals and
fbconfigs for rendering.

Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Marek Olšák <marek.olsak@amd.com>

net..@..ail.ru said:

bug 104540 is probably the very same issue, since OBS uses Xcomposite to capture a window.

net..@..ail.ru closed a related bug:

*** Bug 104540 has been marked as a duplicate of this bug. ***

Mario Kleiner said:

Can you try what happens if you add the following snippet inside the <device> section of your /etc/drirc and restart compton?

<application name="compton" executable="compton"> </application>

The output of xdpyinfo and glxinfo could also be useful.

To disable the new rgb10 support globally, one can add this snippet instead:

>>>

Christoph Haag uploaded an attachment:

No need to add to drirc, you can also set drirc options with an environment variable.

This indeed works fine, no color issue: allow_rgb10_configs=false compton --backend glx

Attachment 136700, "xdpyinfo":
xdpyinfo.txt

Christoph Haag uploaded an attachment:

Attachment 136701, "glxinfo":
glxinfo.txt

Mario Kleiner said:

compton didn't cause problems for me under default 24 bit color-depth on X-Server 1.19.3.

But Christoph's setup is running the new server 1.19.6, and the glxinfo shows various new 32 bit visuals, not only rgba 8 8 8 8 but also rgba 10 10 10 2.

1.19.6 contains the patch "glx: Duplicate relevant fbconfigs for compositing visuals" backported from master, adding lots new 32 bpp compositing visuals, so that might trigger the problems?

Fredrik Höglund @fredrik said:

The broken window preview is actually a bug in plasma.

The thumbnail code doesn't look at the sizes of the color channels; it only checks that the GLX_BUFFER_SIZE matches the depth of the window.

Mario Kleiner submitted a patch:

This patch fixes the problem with compton, as tested against server 1.19 branch. Also applies cleanly against master, but i haven't tested it on master yet.

So far tested with KDE-5, compiz, and compton, on ati-ddx under Radeon gfx, both screen depth 24 and 30.

Patch 137087, "Possible fix, tested against server 1.19 branch.":
0001-glx-Only-assign-8-bpc-fbconfigs-for-composite-visual.patch

Thomas Crider said:

(In reply to Mario Kleiner from comment 10)

Created attachment 137087 [details] [review] Possible fix, tested against server 1.19 branch.

This patch fixes the problem with compton, as tested against server 1.19 branch. Also applies cleanly against master, but i haven't tested it on master yet.

So far tested with KDE-5, compiz, and compton, on ati-ddx under Radeon gfx, both screen depth 24 and 30.

tested here 1.19 as well, sadly does not fix the issue with OBS xcomposite window capture mentioned in https://bugs.freedesktop.org/show_bug.cgi?id=104540

Thomas Crider said:

(In reply to Mario Kleiner from comment 5)

Can you try what happens if you add the following snippet inside the <device> section of your /etc/drirc and restart compton?

<application name="compton" executable="compton"> </application>

The output of xdpyinfo and glxinfo could also be useful.

To disable the new rgb10 support globally, one can add this snippet instead:

adding this for obs resolves https://bugs.freedesktop.org/show_bug.cgi?id=104540

<application name="obs" executable="obs"> </application>

Michel Dänzer @daenzer said:

(In reply to gloriouseggroll from comment 12)

adding this for obs resolves https://bugs.freedesktop.org/show_bug.cgi?id=104540

That probably means it's an OBS bug, not handling 10bpc configs correctly. Please report it to the OBS developers.

Luke A. Guest said:

Looks like it's the same as https://obsproject.com/forum/threads/xcomposite-colours-all-wrong.81265/ and https://obsproject.com/forum/threads/xcomposite-window-capture-not-working.81389/.

It's been pointed out it's not Obs as TyMiles2012 moved back from the Oibaf PPA on Ubuntu 17.10.1 back to standard drivers and it no longer affects him.

Michel Dänzer @daenzer said:

(In reply to Luke A. Guest from comment 14)

It's been pointed out it's not Obs as TyMiles2012 moved back from the Oibaf PPA on Ubuntu 17.10.1 back to standard drivers and it no longer affects him.

That doesn't mean it's a Mesa bug, just that the OBS issue was triggered by a change in Mesa's behaviour (it now exposes 10-bit-per-component colour configs).

Dave Gilbert closed a related bug:

*** Bug 105824 has been marked as a duplicate of this bug. ***

Timothy Arceri @tarceri closed a related bug:

*** Bug 105918 has been marked as a duplicate of this bug. ***

Christian König closed a related bug:

*** Bug 108937 has been marked as a duplicate of this bug. ***

Not a Mesa bug, closing.