radv regression bisected: Flickering textures (vega)
Hello,
I bisected an issue that causes some sporadic flickering textures:
92337aff030d5895ddde07f03a918dd416172a9b is the first bad commit
commit 92337aff030d5895ddde07f03a918dd416172a9b
Author: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Date: Mon Apr 29 10:42:22 2024 +0200
radv: split cmdbuf dirty flags into dirty/dirty_dynamic
We are out of bits.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29039>
src/amd/vulkan/meta/radv_meta.c | 2 +-
src/amd/vulkan/radv_cmd_buffer.c | 230 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------
src/amd/vulkan/radv_cmd_buffer.h | 35 +++++++++++++++++-------------
3 files changed, 145 insertions(+), 122 deletions(-)
In CS2 (for example, this may happen in other applications?), this leads to a few spots where textures start flickering with dark colors. I can show an example of 2 frames while a model is flickering, one frame has black textures, the other has a correct texture, this flickers ar high speed. In CS2 this happens on some gun models, on hands, sometimes on shadows (it seems related to illumination and shadows somehow) and depends on places and maps.
For example a good way to reproduce in my case is left-click maintaining a smoke grenade in dust2 T-spawn and moving around, the hand starts flickering. (I can provide more data on how to reproduce if needed)
Kernel : 6.8.8 drm: 2.4.120 GPU: vega 64