Large regression in `glbench --tests context` on Intel
When updating from 23.2 to 23.3 on Intel platforms, we noticed a large regression in glbench --tests context
on some, but not all, platforms. It seems to be most severe on Celeron 7305, ADL GT2. glbench is available at https://chromium.googlesource.com/chromiumos/platform/glbench/
I bisected to commit 6f1b1d63 ("intel/genxml: Auto-import genxml files using genxml_import.py") and manually confirmed the result.
Running the command mentioned in the commit message (src/intel/genxml/genxml_import.py --flatten
) indeed brings the performance back. E.g. testing main
from today:
zavala-rev6 ~ # /usr/local/glbench/bin/glbench --tests context
[minigbm:i915.c(472)] Environment variable ENABLE_INTEL_MEDIA_COMPRESSION is not set. Media compression will be disabled.
# board_id: Intel - Mesa Intel(R) Graphics (ADL GT2)
# MAX_VIEWPORT_DIMS=(16384, 16384)
# GL_MAX_TEXTURE_SIZE=16384
# Running: /usr/local/glbench/bin/glbench --tests context
# DateTime: Wed Dec 20 11:51:09.258702 2023
Bench: Cooled down to 84.0'C (initial=84.0'C) after waiting 0.0s.
# DateTime: Wed Dec 20 11:51:11.437706 2023
@RESULT: context_nogl = 483397.02 us [none]
Bench: Cooled down to 84.0'C (initial=84.0'C) after waiting 0.0s.
# DateTime: Wed Dec 20 11:51:12.782205 2023
@RESULT: context_glsimple = 467026.85 us [context_glsimple.pixmd5-ce090b8accbe11854048896ab343f463.png]
# DateTime: Wed Dec 20 11:51:12.796765 2023
@TEST_END
And after running src/intel/genxml/genxml_import.py --flatten
:
zavala-rev6 ~ # /usr/local/glbench/bin/glbench --tests context
[minigbm:i915.c(472)] Environment variable ENABLE_INTEL_MEDIA_COMPRESSION is not set. Media compression will be disabled.
# board_id: Intel - Mesa Intel(R) Graphics (ADL GT2)
# MAX_VIEWPORT_DIMS=(16384, 16384)
# GL_MAX_TEXTURE_SIZE=16384
# Running: /usr/local/glbench/bin/glbench --tests context
# DateTime: Wed Dec 20 11:55:36.266425 2023
Bench: Cooled down to 84.0'C (initial=84.0'C) after waiting 0.0s.
# DateTime: Wed Dec 20 11:55:39.764282 2023
@RESULT: context_nogl = 1346.42 us [none]
Bench: Cooled down to 84.0'C (initial=84.0'C) after waiting 0.0s.
# DateTime: Wed Dec 20 11:55:42.838131 2023
@RESULT: context_glsimple = 1327.70 us [context_glsimple.pixmd5-ce090b8accbe11854048896ab343f463.png]
# DateTime: Wed Dec 20 11:55:42.857569 2023
@TEST_END
We wouldn't care much about regressions on this test, except it went from ~1000 microseconds to half a second.