Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • crucible crucible
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • cruciblecrucible
  • Merge requests
  • !48

Merged
Created Aug 23, 2019 by Caio Oliveira@cmarceloDeveloper

func.shader-ballot.builtins: Don't set bits after gl_SubGroupSize-1

  • Overview 2
  • Commits 1
  • Changes 1

According to description of SubgroupGeMask decoration in Vulkan spec

The bits corresponding to the invocations greater than or equal to
SubgroupLocalInvocationId through SubgroupSize-1 are set in the
variable decorated with SubgroupGeMask. All other bits are set to
zero.

Similar restriction applies to others. So when building bitmasks to compare with the builtins, ensure that they don't set the wrong bits. Note that the Lt/Le expected bitmasks don't set larger bits, so don't need to be masked.

Fixes: e42ad5a5 ("add AMD_shader_ballot tests")

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: r/fix-ballot-builtins