- May 30, 2019
-
-
Adam Jackson authored
Signed-off-by: Adam Jackson <ajax@redhat.com>
-
- May 28, 2019
-
-
Terms: dev->last.valuator[] is the last value given to us by the driver dev->valuator.axisVal[] is the last value sent to the client dev->last.scroll[] is the abs value of the scroll axis as given by the driver, used for button emulation calculation (and the remainder) This function updates the device's last.valuator state based on the current master axis state. This way, relative motion continues fluidly when switching between devices. Before mouse 2 comes into effect, it's valuator state is updated to wherever the pointer currently is so the relative event applies on top of that. This can only work for x/y axes, all other axes aren't guaranteed to have the same meaning and/or may not be present: - xtest device: no valuator 2 - mouse: valuator 2 is horizontal scroll axis - tablet: valuator 2 is pressure Scaling the current value from the pressure range into the range for horizontal scrolling makes no sense. And it causes scroll jumps: - scroll down, last.valuator == axisVal == 20 - xdotool click 1, the XTest device doesn't have that valuator - scroll up - updateSlaveDeviceCoords reset last.valuator to 0 (axisVal == 20) - DeviceClassesChangedEvent includes value 20 for the axis - event is processed, last.value changes from 0 to -1 - axisVal is updated to -1, causing a jump of -21 The same applies when we switch from tablet to mouse wheel if the pressure value is 0 on proximity out (basically guaranteed). So let's drop this code altogether and only leave the scaling for the relative x/y motion. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit d7b1753d)
-
- May 20, 2019
-
-
If `_glamor_create_tex()` fails to allocate the FBO because of GL_OUT_OF_MEMORY error, the `pixmap_priv->fbo` is NULL. However, `glamor_get_pixmap_texture()` doesn't actually check whether the `pixmap_priv->fbo` is NULL and will segfault with a NULL pointer dereference trying to access the `pixmap_priv->fbo->tex`. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com> Closes: xorg/xserver#647 (Cherry picked from commit 74479a99)
-
- Apr 05, 2019
-
-
Found by coverity Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (Cherry picked from commit 7c25439f)
-
wl_drm's protocol "device" event provides the path to the DRM device, which may not be a render node, thus causing Xwayland to fall back to DRM authentication which may fail if the user has switched to another VT while Xwayland is starting. Search for a render node corresponding to the given DRM device and try to use it instead, as render nodes do not need DRM authentication and Xwayland can make use of them if it can find one. Closes: https://bugs.freedesktop.org/108038 Signed-off-by: Olivier Fourdan <ofourdan@redhat.com> (Cherry picked from commit 36189449)
-
- Mar 25, 2019
-
-
If they don't, flipping will result in corrupted display. Test case: * Run Xorg at 1920x1080 with no window manager * glxgears -geometry 2048x1080 (Cherry picked from commit ef91da27)
-
xwl_present_cleanup frees the struct xwl_present_window memory, so if there's a pending callback, we have to destroy it to prevent use-after-free in xwl_present_sync_callback. Should fix issue #645. Reviewed-by: Olivier Fourdan <ofourdan@redhat.com> (Cherry picked from commit 2e18eec6)
-
This reverts commit 8694395f. Some scenarios have come to light where this failed to ensure the docker image exists: * If the master branch of a forked repository is used for an MR which doesn't modify .gitlab-ci.yml, the docker-image job may not run. * If the docker-image job of the first pipeline in a forked repository is cancelled or fails for any reason, and .gitlab-ci.yml isn't modified for the next pipeline run. (Cherry picked from commit 0ec9a13c)
-
- Mar 21, 2019
-
-
If the server resets, most client workqueues are cleaned up as the clients are killed. The one exception is the server's client, which is exempt from the killing spree. If that client has a queued work procedure active, it won't get cleared on reset. This commit ensures it gets cleared too. (cherry picked from commit 8738ce85) Fixes: xorg/xserver#670
-
- Feb 25, 2019
-
-
Adam Jackson authored
Signed-off-by: Adam Jackson <ajax@redhat.com>
-
We don't set the PIGLIT_DIR and XTS_DIR environment variables for make distcheck for now, otherwise it complains about files left behind by piglit. (cherry picked from commit 432fad04)
-
Guard BUILT_SOURCES and CLEANFILES by XWIN_GLX_WINDOWS/XQUARTZ. (cherry picked from commit f9bbc9d5)
-
- Feb 22, 2019
-
-
Instead of testing window->redirectDraw. With Xwayland, the toplevel window is always redirected, so this would unnecessarily preclude flipping there in some cases, e.g. with wlroots based Wayland compositors or with fullscreen X11 windows in weston. Fixes issue #631. (Cherry picked from commit a093a885)
-
Michel Dänzer authored
(Cherry picked from commit 2f12c801)
-
Michel Dänzer authored
Meson picks it up automatically. Based on: * mesa/mesa!240 * https://gould.cx/ted/blog/2017/06/10/ccache-for-Gitlab-CI/ * https://stackoverflow.com/questions/53659419/ccache-no-hits-in-gitlab-ci v2 based on the corresponding Mesa change: * Quote CCACHE_(BASE)DIR environment variables. * Clear ccache stats in before_script. * Move cache stanza to the build-and-test job, the cache isn't used in the docker-image job. Reviewed-by: Adam Jackson <ajax@redhat.com> # v1 (Cherry picked from commit b577df77)
-
Michel Dänzer authored
We're going to make use of these in build & test jobs. (Cherry picked from commit 537f06e2)
-
Michel Dänzer authored
The name of a forked repository can be changed later, in which case this would fail to refer to the main repository. Pointed out by Eric Engestrom in mesa/mesa!224 . (Cherry picked from commit fede3849)
-
Michel Dänzer authored
Otherwise there's normally no need to run it. It will also run when a new branch is created, which ensures that the docker image always exists (e.g. in a newly forked repository). Inspired by mesa/mesa!143 (Cherry picked from commit 8694395f)
-
Michel Dänzer authored
Although piglit could now handle non-ASCII characters in the environment, meson was still failing without this (even though it's using Python 3). Reviewed-by: Eric Anholt <eric@anholt.net> (Cherry picked from commit bc6998b7)
-
Michel Dänzer authored
The latter use Python 2 and break with any non-ASCII characters in the environment, the former uses Python 3 and works fine in that case. Reviewed-by: Eric Anholt <eric@anholt.net> (Cherry picked from commit 4aaaf692)
-
Michel Dänzer authored
This removes the dependency on an externally generated docker image, and should make it easier to update the docker image or make other changes related to it. This is based on Debian testing, because I'm most familiar with Debian. But it should be easy to base it on another distro. v2: * Use kaniko instead of docker-in-docker for image generation, so it can also work in unprivileged runners. * Drop piglit.conf & tetexec.cfg overrides, just make sure the files in the image work. (Cherry picked from commit f56d8e22)
-
Michel Dänzer authored
Fold build-travis-deps.sh into .gitlab-ci.yml. Preparation for the next change, which would break the Travis Linux build. Reviewed-by: Eric Anholt <eric@anholt.net> (Cherry picked from commit ed44f9cd)
-
Can be useful for figuring out what caused the failure. (Cherry picked from commit a7472da9)
-
The prefix setting didn't take for some reason. (Cherry picked from commit c1bb392b)
-
No idea which cult's cargo I was looking at there. Cuts about a minute off the build time. Signed-off-by: Adam Jackson <ajax@redhat.com> (Cherry picked from commit a41ccaa0)
-
- Feb 20, 2019
-
-
The input thread checks the barriers for pointer positioning, swapping the list out from underneath is considered impolite. Reported-by: Michel Dänzer <michel.daenzer@amd.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> (cherry picked from commit 678d64aa)
-
GetTimeInMillis is called first, which sets clockid to CLOCK_MONOTONIC_COARSE, which is typically much lower resolution than the callers of GetTimeInMicros want. Prior to a779fda2, GetTimeInMillis and GetTimeInMicros did not share a clockid. Restore the clockid split to fix the granularity of GetTimeInMicros. Signed-off-by: Peter Harris <pharris@opentext.com> (cherry picked from commit 937a5b78)
-
A user of Adélie Linux reported that modesetting wasn't working properly on their Intel i7-9700K-integrated UHD 630 GPU. Xorg.0.log showed: [ 131.902] (EE) modeset(0): [DRI2] No driver mapping found for PCI device 0x8086 / 0x3e98 [ 131.902] (EE) modeset(0): Failed to initialize the DRI2 extension. Indeed, that PCI ID is missing from i965_pci_ids. Adding it fixed the issue and allowed the system to work with i965_dri under modesetting. (cherry picked from commit d3a26bbf)
-
Adam Jackson authored
'disp' was already allocated by LookupVendorPrivDispatch above, clobbering it will do no good. Signed-off-by: Adam Jackson <ajax@redhat.com> (cherry picked from commit 709c6562)
-
Adam Jackson authored
Both because extension names are inconsistently capitalized on the wire, and because the table we're walking spells it COMPOSITE not Composite. The latter is certainly also a bug, but there's no reason for us to be that strict. Signed-off-by: Adam Jackson <ajax@redhat.com> (cherry picked from commit bf991a5f)
-
Adam Jackson authored
Neither opening a screen nor querying its modifiers confers the right to attach the buffer for any particular pixmap. GetAttr seems more correct. Fixes: xorg/xserver#550 (cherry picked from commit 086c2e3d)
-
If the driver calls xf86HandleColormaps, CMapChangeGamma updates the HW gamma LUT of all CRTCs via xf86RandR12LoadPalette. However, xf86RandR12ChangeGamma was then clobbering the gamma LUT of the RandR 1.2 compatibility output's CRTC with the gamma curves computed from the screen's global gamma values. Fix this by bailing if xf86RandR12LoadPalette is installed. Fixes: 02ff0a5d "xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error" (cherry picked from commit 30044b22)
-
(cherry picked from commit e3fb1786)
-
(cherry picked from commit bf2a7bb4)
-
Fixes: xorg/xserver#469 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> (cherry picked from commit 7fb6338c)
-
Fixes x2r10g10b10 related rendercheck failures. Reviewed-by: Eric Anholt <eric@anholt.net> (cherry picked from commit 7e6faa5b)
-
Broken since 69d8ea4a because our fake screen didn't have a root window and writing the XKB rules prop would happily segfault. Fix this by setting up the required bits. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Tested-by: Michel Dänzer <michel.daenzer@amd.com> (cherry picked from commit fde27b9b)
-
Noticed when porting this logic to xf86-video-nouveau, and valgrind complained about conditional jump based on uninitialized data. Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.com> (cherry picked from commit 48b1af27)
-
Adam Jackson authored
Fixes: xorg/xserver#17 (cherry picked from commit 82ed89c0)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit a425eee6)
-