- Feb 26, 2019
-
-
Tim-Philipp Müller authored
-
- Feb 14, 2019
-
-
Tim-Philipp Müller authored
-
- Jan 25, 2019
-
-
Simplify the code and so we advertise the formats actually supported by gst-omx.
-
cpb-size cannot be smaller than initial-delay.
-
The 'finish' function do the exact same check / drop, there is no need to duplicate this here.
-
The omxvideodec base class have a totally unused prepare_frame() vritual function, remove it.
-
Added adaptive gop-mode option to ZYNQ_USCALE_PLUS encoder properties
-
Instead of going through a full reset, try and change the framerate config on the encoder when only the framerate have change.
-
- Jan 17, 2019
-
-
Tim-Philipp Müller authored
-
- Jan 09, 2019
-
-
As the pi, the zynq has its own API to request keyframe.
-
- Jan 08, 2019
-
-
Guillaume Desmottes authored
If buffers were released from the pool while gst_omx_video_enc_handle_frame() was waiting for new buffers, gst_omx_port_acquire_buffer() was never awaken as the buffers weren't released through OMX's messaging system. GQueue isn't thread safe so also protect it with the lock mutex.
-
- Dec 21, 2018
-
-
We used to track the 'allocating' status on the pool. It is used while allocating so output buffers aren't passed right away to OMX and input ones are not re-added to the pending queue. This was causing a bug when exporting buffers to v4l2src. On start v4l2src acquires a buffer, read its stride and release it right away. As no buffer was received by the encoder element at this point, 'allocating' was still on TRUE and so the the buffer wasn't put back to the pending queue and, as result, no longer available to the pool. Fix this by checking the active status of the pool instead of manually tracking it down. The pool is considered as active at the very end of the activation process so we're good when buffers are released during the activation.
-
- Dec 05, 2018
-
-
Thibault Saunier authored
From ed78bee to 59cb678
-
- Nov 26, 2018
-
-
Guillaume Desmottes authored
The GType was missing from the second field of the struct.
-
- Nov 05, 2018
-
-
Matthew Waters authored
-
- Sep 26, 2018
-
-
Guillaume Desmottes authored
This debug category can now be used to track more OMX calls and events so best to rename it to something more generic. https://bugzilla.gnome.org/show_bug.cgi?id=797171
-
- Sep 19, 2018
-
-
Guillaume Desmottes authored
It has been useful to have a clear raw and structured view of the gst <-> OMX exchanges when debugging. https://bugzilla.gnome.org/show_bug.cgi?id=797171
-
Guillaume Desmottes authored
No semantic change. I'm going to add extra debug in this function. https://bugzilla.gnome.org/show_bug.cgi?id=797171
-
Guillaume Desmottes authored
It has been useful to have a clear raw and structured view of the gst <-> OMX exchanges when debugging. https://bugzilla.gnome.org/show_bug.cgi?id=797171
-
Guillaume Desmottes authored
I'm about to log more things under this category https://bugzilla.gnome.org/show_bug.cgi?id=797171
-
- Sep 10, 2018
-
-
Nicolas Dufresne authored
The method we call in the context of pushing a buffer are all thread safe. Holding a lock would prevent input buffers from being queued while pushing. https://bugzilla.gnome.org/show_bug.cgi?id=715192
-
Nicolas Dufresne authored
We only enter this branch if nFilledLen > 0, there is not need to check again. https://bugzilla.gnome.org/show_bug.cgi?id=715192
-
Nicolas Dufresne authored
This was forgotton in previous patch. We no long hold the lock when goto invalid_buffer is called. https://bugzilla.gnome.org/show_bug.cgi?id=715192
-
- Aug 31, 2018
-
-
Nicolas Dufresne authored
The base class methods will lock this properly when needed, there seems to be no need to lock it explicitly. This allows the patch in gstvideodec for unlocking the stream lock when pushing buffers out to work. https://bugzilla.gnome.org/show_bug.cgi?id=715192
-
- Aug 30, 2018
-
-
Guillaume Desmottes authored
We already have code configuring the encoder stride and slice height when receiving the first buffer from upstream. We don't have an equivalent when the encoder is exporting its buffers to the decoder. There is no point adding it and making the code even more complex as we wouldn't gain anything by exporting from the encoder to the decoder. The dynamic buffer mode already ensures 0-copy between OMX components. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
Propose pool upstream so input buffers can be allocated by the port and exported as dmabuf. The actual OMX buffers are allocated when the pool is activated, so we don't end up doing useless allocations if the pool isn't used. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
Will be needed to implement GST_BUFFER_POOL_ACQUIRE_FLAG_DONTWAIT. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
Fix 'omxh264dec ! videocrop' pipeline. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
No semantic change, just make the code clearer and improve debug output. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
The "use buffers" code path uses gst_video_info_from_caps() which is asserting if caps is NULL (because pool was rejected). https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
gst_buffer_pool_config_get_params() doesn't ref the returning caps; so gst_caps_replace() was unreffing the reference owned by the pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
The OMX transition state to Loaded won't be complete until all buffers have been freed. There is no point waiting, and timeout, if we know that output buffers haven't been freed yet. The typical scenario is output buffers being still used downstream and being freed later when released back to the pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
Now that the pool is responsible of freeing the OMX buffers, we need to ensure that the OMX component stay alive while the pool is as we rely on the component to free the buffers. The GstOMXPort is owned by the component so no need to ref this one. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
Will use it for refcounting. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
The pool is stopped when all the buffers have been released. Deallocate when stopping so we are sure that the buffers aren't still used by another element. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
When using a input buffer pool, the buffer may be released to the pool when gst_omx_buffer_unmap() is called. We need to have buf->used unset at this point as the pool may use it to check the status of the pool. {Empty,Fill}BufferDone is called from OMX internal threads while messages are handled from gst elements' thread. Best to do all this when handling the message so we don't mess with OMX threads and keep the original thread/logic split. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
This is no longer needed since we implemented close() vfuncs as the encoder/decoder base class already take care of calling close() (which is calling shutdown()) in its own change_state implementation. We also move the shut down of the component from PAUSED_TO_READY to READY_TO_NULL. By doing so upstream will have already deactivated the pool from the encoder and so won't be preventing the OMX state change as the buffers will all be released. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
Move the qdata code to helper functions as I'm going to need them in omxvideoenc to implement dmabuf export. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
No semantic change. We'll have to use this when the input pool is activated so we can allocate buffers. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-
Guillaume Desmottes authored
Will add extra code when adding input buffer pool. https://bugzilla.gnome.org/show_bug.cgi?id=796918
-