-
- Downloads
powerpc/ps3: make system bus's remove and shutdown callbacks return void
The driver core ignores the return value of struct device_driver::remove because there is only little that can be done. For the shutdown callback it's ps3_system_bus_shutdown() which ignores the return value. To simplify the quest to make struct device_driver::remove return void, let struct ps3_system_bus_driver::remove return void, too. All users already unconditionally return 0, this commit makes it obvious that returning an error code is a bad idea and ensures future users behave accordingly. Signed-off-by:Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by:
Geert Uytterhoeven <geert@linux-m68k.org> Acked-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20201126165950.2554997-2-u.kleine-koenig@pengutronix.de
Showing
- arch/powerpc/include/asm/ps3.h 2 additions, 2 deletionsarch/powerpc/include/asm/ps3.h
- arch/powerpc/platforms/ps3/system-bus.c 2 additions, 3 deletionsarch/powerpc/platforms/ps3/system-bus.c
- drivers/block/ps3disk.c 1 addition, 2 deletionsdrivers/block/ps3disk.c
- drivers/block/ps3vram.c 1 addition, 2 deletionsdrivers/block/ps3vram.c
- drivers/char/ps3flash.c 1 addition, 2 deletionsdrivers/char/ps3flash.c
- drivers/net/ethernet/toshiba/ps3_gelic_net.c 1 addition, 2 deletionsdrivers/net/ethernet/toshiba/ps3_gelic_net.c
- drivers/ps3/ps3-lpm.c 1 addition, 2 deletionsdrivers/ps3/ps3-lpm.c
- drivers/ps3/ps3-vuart.c 4 additions, 6 deletionsdrivers/ps3/ps3-vuart.c
- drivers/scsi/ps3rom.c 1 addition, 2 deletionsdrivers/scsi/ps3rom.c
- drivers/usb/host/ehci-ps3.c 1 addition, 3 deletionsdrivers/usb/host/ehci-ps3.c
- drivers/usb/host/ohci-ps3.c 1 addition, 3 deletionsdrivers/usb/host/ohci-ps3.c
- drivers/video/fbdev/ps3fb.c 1 addition, 3 deletionsdrivers/video/fbdev/ps3fb.c
- sound/ppc/snd_ps3.c 1 addition, 2 deletionssound/ppc/snd_ps3.c
Loading
Please register or sign in to comment