treewide: Convert del_timer*() to timer_shutdown*()
Due to several bugs caused by timers being re-armed after they are shutdown and just before they are freed, a new state of timers was added called "shutdown". After a timer is set to this state, then it can no longer be re-armed. The following script was run to find all the trivial locations where del_timer() or del_timer_sync() is called in the same function that the object holding the timer is freed. It also ignores any locations where the timer->function is modified between the del_timer*() and the free(), as that is not considered a "trivial" case. This was created by using a coccinelle script and the following commands: $ cat timer.cocci @@ expression ptr, slab; identifier timer, rfield; @@ ( - del_timer(&ptr->timer); + timer_shutdown(&ptr->timer); | - del_timer_sync(&ptr->timer); + timer_shutdown_sync(&ptr->timer); ) ... when strict when != ptr->timer ( kfree_rcu(ptr, rfield); | kmem_cache_free(slab, ptr); | kfree(ptr); ) $ spatch timer.cocci . > /tmp/t.patch $ patch -p1 < /tmp/t.patch Link: https://lore.kernel.org/lkml/20221123201306.823305113@linutronix.de/ Signed-off-by:Steven Rostedt (Google) <rostedt@goodmis.org> Acked-by: Pavel Machek <pavel@ucw.cz> [ LED ] Acked-by: Kalle Valo <kvalo@kernel.org> [ wireless ] Acked-by: Paolo Abeni <pabeni@redhat.com> [ networking ] Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- arch/sh/drivers/push-switch.c 1 addition, 1 deletionarch/sh/drivers/push-switch.c
- block/blk-iocost.c 1 addition, 1 deletionblock/blk-iocost.c
- block/blk-iolatency.c 1 addition, 1 deletionblock/blk-iolatency.c
- block/kyber-iosched.c 1 addition, 1 deletionblock/kyber-iosched.c
- drivers/acpi/apei/ghes.c 1 addition, 1 deletiondrivers/acpi/apei/ghes.c
- drivers/atm/idt77252.c 3 additions, 3 deletionsdrivers/atm/idt77252.c
- drivers/block/drbd/drbd_main.c 1 addition, 1 deletiondrivers/block/drbd/drbd_main.c
- drivers/block/loop.c 1 addition, 1 deletiondrivers/block/loop.c
- drivers/bluetooth/hci_bcsp.c 1 addition, 1 deletiondrivers/bluetooth/hci_bcsp.c
- drivers/gpu/drm/i915/i915_sw_fence.c 1 addition, 1 deletiondrivers/gpu/drm/i915/i915_sw_fence.c
- drivers/hid/hid-wiimote-core.c 1 addition, 1 deletiondrivers/hid/hid-wiimote-core.c
- drivers/input/keyboard/locomokbd.c 1 addition, 1 deletiondrivers/input/keyboard/locomokbd.c
- drivers/input/keyboard/omap-keypad.c 1 addition, 1 deletiondrivers/input/keyboard/omap-keypad.c
- drivers/input/mouse/alps.c 1 addition, 1 deletiondrivers/input/mouse/alps.c
- drivers/isdn/mISDN/l1oip_core.c 2 additions, 2 deletionsdrivers/isdn/mISDN/l1oip_core.c
- drivers/isdn/mISDN/timerdev.c 2 additions, 2 deletionsdrivers/isdn/mISDN/timerdev.c
- drivers/leds/trigger/ledtrig-activity.c 1 addition, 1 deletiondrivers/leds/trigger/ledtrig-activity.c
- drivers/leds/trigger/ledtrig-heartbeat.c 1 addition, 1 deletiondrivers/leds/trigger/ledtrig-heartbeat.c
- drivers/leds/trigger/ledtrig-pattern.c 1 addition, 1 deletiondrivers/leds/trigger/ledtrig-pattern.c
- drivers/leds/trigger/ledtrig-transient.c 1 addition, 1 deletiondrivers/leds/trigger/ledtrig-transient.c
Loading
Please register or sign in to comment