Skip to content

nm-dispatcher-drop-the-idle-timeout

Luis Gomez requested to merge drop-idle-timeout into main

nm-dispatcher was designed to be "exit-on-idle". This is broken by design when used as a bus activated service because when systemd schedules the dbus daemon to be shutdown, like at shutdown time, it is not possible to also activate bus services. This means that at shutdown time, nm-dispatcher disconnect hooks can never proceed.

There is no real advantage to making the dispatcher exit-on-idle, it is a small daemon without significant overhead. To fix this error, leave the bus activation in place so that the dispatcher is started on-demand, but drops the idle timeout and undocumented "--persist" flag, making persist the default and only behavior of nm-dispatcher.

Checklist

Please read https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/CONTRIBUTING.md before opening the merge request. In particular, check that:

  • the subject for all commits is concise and explicative
  • the message for all commits explains the reason for the change
  • the source is properly formatted
  • any relevant documentation is up to date
  • you have added unit tests if applicable
  • the NEWS file is updated when the change deserves to be mentioned, for example for new features, behavior changes, API deprecations, etc.

Merge request reports