Skip to content
Snippets Groups Projects
  1. Aug 27, 2014
  2. Aug 23, 2014
    • Tim-Philipp Müller's avatar
      queue: fix race when flush-stop event comes in whilst shutting down · 902a5e6b
      Tim-Philipp Müller authored
      Don't re-start the queue push task on the source pad when a
      flush-stop event comes in and we're in the process of shutting
      down, otherwise that task will never be stopped again.
      
      When the element is set to READY state, the pads get de-activated.
      The source pad gets deactivated before the queue's own activate_mode
      function on the source pads gets called (which will stop the thread),
      so checking whether the pad is active before re-starting the task on
      receiving flush-stop should be fine. The problem would happen when the
      flush-stop handler was called just after the queue's activate mode
      function had stopped the task.
      
      Spotted and debugged by Linus Svensson <linux.svensson@axis.com>
      
      https://bugzilla.gnome.org/show_bug.cgi?id=734688
      902a5e6b
    • Thiago Santos's avatar
      inputselector: always proxy caps query · ffa14610
      Thiago Santos authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Otherwise it would only be proxied for the active pad which can lead
      upstream to use an incompatible caps for the downstream element.
      
      Even if a reconfigure event is sent upstream when the pad is activated, this
      will save the caps reconfiguration if it is already using an acceptable caps.
      ffa14610
  3. Aug 14, 2014
  4. Aug 13, 2014
  5. Aug 11, 2014
    • Руслан Ижбулатов's avatar
      poll: Prevent false-negative from WAKE_EVENT() on W32 · 067604b2
      Руслан Ижбулатов authored and Sebastian Dröge's avatar Sebastian Dröge committed
      SetEvent() seems to not call SetLastError(0) internally, so checking last
      error after calling SetEvent() may return the error from an earlier W32 API
      call. Fix this by calling SetlastError(0) explicitly.
      
      Currently WAKE_EVENT() code is cramped into a macro and doesn't look to be
      entirely correct. Particularly, it does not check the return value of
      SetEvent(), only the thread-local W32 error value. It is likely that SetEvent()
      actually just returns non-zero value, but the code mistakenly thinks that the
      call has failed, because GetLastError() seems to indicate so.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=733805
      067604b2
  6. Jul 30, 2014
  7. Jul 28, 2014
  8. Jul 27, 2014
  9. Jul 22, 2014
  10. Jul 19, 2014
  11. Jul 17, 2014
  12. Jul 16, 2014
  13. Jul 14, 2014
  14. Jul 11, 2014
  15. Jul 09, 2014
  16. Jul 08, 2014
  17. Jul 07, 2014
  18. Jul 06, 2014
  19. Jul 05, 2014
  20. Jul 04, 2014
  21. Jul 03, 2014
  22. Jul 02, 2014
Loading