- Jul 31, 2017
-
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Since array splitting for AoA is disabled, we have to retrieve the type of the first non-array type when an array of images is declared inside a structure. Otherwise, it will hit an assert in glsl_type::sampler_index() because it expects either a sampler or an image type. This fixes a regression in the following piglit test: arb_bindless_texture/compiler/images/arrays-of-struct.frag Fixes: 57165f2e ("glsl: disable array splitting for AoA") Cc: 17.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit f99e9335)
-
Noticed randomly. Cc: 17.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> (cherry picked from commit 5c124126)
-
On SI this was causing a hang in dEQP-VK.pipeline.render_to_image.core.2d_array.mipmap.r16g16_sint_s8_uint This was due to not handling the tile mode index for depth like I fixed previously for new GPUs. Fixes: 01d0c5a9 (radv: fix stencil regression since new addrlib import) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 800d1622)
-
The host doesn't understand this yet, so drop it for now. Fixes: virgl regressions. Fixes: af22adee (tgsi: add precise flag to tgsi_instruction) Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 554aa094)
-
This fixes corruption with bindless textures in Dawn Of War 3. The do_update_surf_dirtiness mechanism was complicated and dirty_level_mask was only updated after the first draw call. The problem is bindless textures are checked for decompression every draw call and we would only decompress after the first draw call. The solution is to set dirtiness after the last draw call to the framebuffer, so the (unconditional) decompression of bindless textures happens at the right time. Cc: 17.2 <mesa-stable@lists.freedesktop.org> Tested-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit f4d095cc)
-
This fixes the black Feral launcher window. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867 Cc: 17.2 <mesa-stable@lists.freedesktop.org> Tested-by:
Edmondo Tommasina <edmondo.tommasina@gmail.com> (cherry picked from commit 7257c171)
-
With merged ESGS shaders, the GS part of a wave may be empty, and the hardware gets confused if any GS messages are sent from that wave. Since S_SENDMSG is executed even when EXEC = 0, we have to wrap even non-monolithic GS shaders in an if-block, so that the entire shader and hence the S_SENDMSG instructions are skipped in empty waves. This change is not required for TCS/HS, but applying it there as well simplifies the logic a bit. Fixes GL45-CTS.geometry_shader.rendering.rendering.* v2: ensure that the TCS epilog doesn't run for non-existing patches Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 081ac6e5)
-
Cc: mesa-stable@lists.freedesktop.org Reviewed: Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 87378900)
-
The shader that is used to copy vertex data out of the vs/gs shaders to the user-specified buffer (streamout or SO shader) was not using the correct offsets. Adjust the offsets that are used just for the SO shader: - Make sure that position is handled in the same special way as in the vs/gs shaders - Use the correct offset to be passed in the core - consolidate register slot mapping logic into one function, since it's been calculated in 2 different places (one for calcuating the slot mask, and one for the register offsets themselves Also make room for all attibutes in the backend vertex area. Fixes: - all vtk GL2PS tests - 18 piglit tests (16 ext_transform_feedback tests, arb-quads-follow-provoking-vertex and primitive-type gl_points v2: - take care of more SGV slots in slot mapping logic - trim feState.vsVertexSize - fix GS interface and incorporate GS while calculating vsVertexSize Note that vsVertexSize is used in the core as the one parameter that controls vertex size between all stages, so it has to be adjusted appropriately for the whole vs/gs/fs pipeline. Also note that GS and SO is not fully implemented. This will be addressed later. fixes: - fixes total of 20 piglit tests CC: 17.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Bruce Cherniak <bruce.cherniak@intel.com> (cherry picked from commit 194ff5ee)
-
- Jul 27, 2017
-
-
This ports 72e46c98 to radv. radeonsi: apply a TC L1 write corruption workaround for SI Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit e77ff11f)
-
This ports: da745366 radeonsi: don't apply the Z export bug workaround to Hainan to radv. Just noticed in passing. Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit a81e99f5)
-
Until we support sync fd, don't report the info. Fixes CTS dEQP-VK.api.external.semaphore.sync_fd.* from crashing. Fixes: eaa56eab (radv: initial support for shared semaphores (v2)) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 6cbc8cf1)
-
Fixes CTS dEQP-VK.memory.pipeline_barrier.host_write_uniform_texel_buffer.1024 on SI/CIK with radv. Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver) Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit ca82ef5a)
-
Always initialise whandle.modifier for DRIImage modifier queries, so if the driver doesn't support it then we return false for the query. Signed-off-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Fixes: d33fe8b8 ("st/dri: enable DRIimage modifier queries") (cherry picked from commit 45383d32)
-
In the DRIImage queryImage hook, check if resource_get_handle() failed and return FALSE if so. Signed-off-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit b4a18f13)
-
If the underlying driver does not support modifiers, dmabuf will still advertise formats through the 'modifier' event, but send them with an invalid modifier. Ignore them if this is the case, rather than passing them through to the driver. Signed-off-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Fixes: 02cc3593 ("egl/wayland: Use linux-dmabuf interface for buffers") (cherry picked from commit dd072cf4)
-
gcc prior to 4.9 didn't implement <regex>, causing a startup crash in the swr knob parameter reading code. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Bruce Cherniak <bruce.cherniak@intel.com> (cherry picked from commit e21fc2c6)
-
Fixes arb_vertex_buffer_object-combined-vertex-index Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit c4652a0a)
-
v2: don't do it for compressed textures (bpp = 0) Cc: 17.2 <mesa-stable@lists.freedesktop.org> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> (v1) Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com> (v1) (cherry picked from commit 5e81df0f)
-
Cc: 17.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> (cherry picked from commit ed2b3f5c)
-
This fixes a bug uncovered by: 2412c4c8 util: Make CLAMP turn NaN into MIN. Cc: 17.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> (cherry picked from commit 433f6f7a)
-
With commit 5124bf98, a framebuffer interface hash table is created in st_gl_api_create(), which is called in dri_init_screen_helper() for each screen. When the hash table is overwritten with multiple calls to st_gl_api_create(), it can cause race condition. This patch fixes the problem by creating a framebuffer interface hash table per state tracker manager. Fixes crash with steam. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101876 Fixes: 5124bf98 ("st/mesa: add destroy_drawable interface") Tested-by:
Christoph Haag <haagch@frickel.club> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit bbc29393) Squashed with: st/mesa: fix unconditional return in st_framebuffer_iface_remove Noticed by James Legg @ Feral. Cc: 17.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 914f11e7) Squashed with: st/mesa: Fix inversed test in st_api_destroy_drawable Fixes a drawable leak. Fixes: bbc29393 ("st/mesa: create framebuffer iface hash table per st manager") Bugzilla: https://bugs.freedesktop.org/101930 Tested-by:
Nick Sarnie <commendsarnex@gmail.com> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit 57132d12)
-
We'll fail to flag an error if the context flags appear after the no-error attribute in the context attribute list. Delay the check to after attribute parsing to fix this. Fixes: 4909519a ("egl: Add EGL_KHR_create_context_no_error support") Cc: mesa-stable@lists.freedesktop.org [Emil Velikov: add fixes/stable tags, commit message polish] Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit 39bf7756)
-
The number of supported waves per thread group has been reduced to 16 with gfx9. Trying to use 32 waves causes hangs, and barriers might not work correctly with > 16 waves. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit a0e6b9a2)
-
The firmware version numbers for SI were wrong. The new numbers are probably too conservative (we don't have a definitive answer by the firmware team), but DRAW_INDIRECT_MULTI has been confirmed to work with these versions on Tahiti (by Gustaw) and on Verde (by myself). While this is technically adding a feature, it's a feature we thought we had for a long time. The change is small enough and we're early enough in the 17.2 release cycle that it should still go in. Reported-by:
Gustaw Smolarczyk <wielkiegie@gmail.com> Cc: 17.2 <mesa-stable@lists.freedesktop.org> Acked-by:
Alex Deucher <alexander.deucher@amd.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 65fbaab0)
-
The EU limit of 128 GRFs should allow 32 vertex elements of 4 GRFs. However, the maximum allowed value of "Vertex URB Entry Read Length" in SIMD8 is 15. And 15 * 8 = 120 gives us a limit of 30 vertex elements. Because we also need to reserve a vertex buffer to upload VertexIndex/InstanceIndex and another to upload DrawID when needed, we can only expose 28. Cc: "17.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit 31f1863a)
-
Cc: "17.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit a848e693)
-
Caught by Coverity (CID 1415680). Cc: "17.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit 698636cc) Fixes: 0f9b609c ("i965/blorp: Do prepare/finish manually")
-
Increase the value, not the pointer to the stack variable. Caught by Coverity (CID 1415574). Not shipped in a real release. Cc: "17.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> (cherry picked from commit f6e674fa) Fixes: 63a43f41 ("i965: Refactor miptree to isl converter and adjustment")
-
I don't know how I managed to leave this here for so long. Found when working on a 1:1 overlapping blit extension for X11. Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 93fec49a)
-
As Chris commented, it makes more sense to have batch buffer flushes before the query. Usually applications like frame_retrace do a series of queries and in that case, with flushes at the end of the queries, we might still have the first query contained in 2 different batchs. More generally it would be quite usual to have the query contained in 2 batch buffers because we never now what's the fill rate of the current batch buffer. If we move the flushing at the beginning of the queries, it's pretty much guaranteed that queries will be contained in a single batch buffer (unless the amount of commands is huge, but then it's only fair to include reloading request times in the measurements). Fixes: adafe4b7 ("i965: perf: minimize the chances to spread queries across batchbuffers") Reported-by:
Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: "17.2 17.1" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 9f439ae1)
-
- Jul 24, 2017
-
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Emil Velikov authored
Fixes: c9cb37b2 ("intel/blorp: Add a partial resolve pass for MCS") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit 5d47dd9c)
-
Emil Velikov authored
Otherwise we'll attemt to generate the header even we don't need to. In that case the dependencies may not be met, leading to build failure. Fixes: 166852ee "configure.ac: rework wayland-protocols handling" Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com>
-
Emil Velikov authored
The extension should be in the list as returned by getExtensions(). Seems to have gone unnoticed since close to nobody wants to change the vblank mode for the software driver. Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Alex Deucher <alexander.deucher@amd.com>
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
This change updates wayland-egl-abi-check.c with the latest changes to wl_egl_window. Signed-off-by:
Miguel A. Vico <mvicomoya@nvidia.com> Reviewed-by:
James Jones <jajones@nvidia.com> Acked-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com>
-
We need wl_egl_window to be a versioned struct in order to keep track of ABI changes. This change makes the first member of wl_egl_window the version number. An heuristic in the wayland driver is added so that we don't break backwards compatibility: - If the first field (version) is an actual pointer, it is an old implementation of wl_egl_window, and version points to the wl_surface proxy. - Else, the first field is the version number, and we have wl_egl_window::surface pointing to the wl_surface proxy. Signed-off-by:
Miguel A. Vico <mvicomoya@nvidia.com> Reviewed-by:
James Jones <jajones@nvidia.com> Acked-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com>
-
mincore() returns 0 on success, and -1 on failure. The last parameter is a vector of bytes with one entry for each page queried. mincore returns page residency information in the first bit of each byte in the vector. Residency doesn't actually matter when determining whether a pointer is dereferenceable, so the output vector can be ignored. What matters is whether mincore succeeds. See: http://man7.org/linux/man-pages/man2/mincore.2.html Signed-off-by:
Miguel A. Vico <mvicomoya@nvidia.com> Acked-by:
Daniel Stone <daniels@collabora.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com>
-