- Dec 07, 2012
-
-
Arun Raghavan authored
-
- Dec 05, 2012
-
-
David Henningsson authored
BugLink: https://bugs.launchpad.net/bugs/1073420 Signed-off-by: David Henningsson <david.henningsson@canonical.com>
-
David Henningsson authored
Added Dell Inspiron 3420, 3520 and Vostro 2420, 2520. Note that this is only necessary for kernels 3.3 to 3.5, as 3.6 has phantom jack support. BugLink: https://bugs.launchpad.net/bugs/1076840 Signed-off-by: David Henningsson <david.henningsson@canonical.com>
-
Arun Raghavan authored
We inadvertantly stopped supporting non-standard rates when the passthrough work was done. This makes sure that if no standard rates are supported, we try to fallback to whatever ALSA gives us.
-
Mikel Astiz authored
The sink can be resumed while the source is still in PA_SOURCE_INIT. This is the case if a module such as module-stream-restore routes the audio to the sink during pa_sink_put(), leading to an inconsistent state: the sink stays RUNNING but the transport is not actually acquired.
-
- Dec 04, 2012
-
-
When a headset is having a profile switch, we can either leave the SCO state unmodified (as it was before this patch) or we can alternatively request it (as older versions of PA). This patch tries to avoid a potential regression in case a module such as module-suspend-on-idle is not present, due to the provided resume-on-running policy. Without this patch, and without such a policy, the sink and sources would stay suspended until the user manually performed another profile switch (i.e. hsp->off->hsp). There are several other solutions currently being discussed as a longer term solution, some of which require extendind the core. This patch is therefore proposed as a short-term workaround to avoid the regression.
-
bt_transport_acquire() might get called from the main thread, in case the IO thread hasn't been started yet. In this case, we should not call setup_stream() since this is going to be called in the beginning of thread_func().
-
If the transport is already acquired and the stream needs to be started, call setup_stream() directly instead of bt_transport_acquire(u, TRUE). Both calls are identical in these conditions, with the exception of the log trace which has now been moved to setup_stream().
-
- Nov 29, 2012
-
-
Headset use-cases shouldn't get affected by this module and the support for A2DP source is interesting, therefore load the module by default.
-
Given that headsets have just one single port exposing whether the audio is streaming (playing) or not, it's not possible that module-bluetooth-policy would distinguish A2DP/HSP cases, and thus the automatic selection of the card profile is not deterministic. For this reason, disable the policy entirely for headsets and focus only on HFGW and A2DP source profiles.
-
Merge the former "hsp-output" and "a2dp-output" ports into one single port, in order to fix the regression of having several independent entries in the UI.
-
Since commit e32a408b, we silence the input memblock in order to give the resampler enough input samples, if necessary. But if there is no need to resample the hrir, the resampled memblock is actually the same as the input memblock. Thus, we have to make sure that we do not silence it in this case.
-
- Nov 22, 2012
-
-
Tanu Kaskinen authored
Without this patch, device modules will be left around after the device has been disconnected and when they are reconnected, the discovery module will load duplicate device module instances. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=57239
-
This is a minor optimization too, but the main benefit is that it's makes the code easier to understand (I hope), since run_callback() won't be called at times when it's not needed.
-
Tanu Kaskinen authored
The new helper function makes it easier to check whether any audio profiles are connected. That information is needed by the discovery module for deciding whether a new device module should be loaded. The device module should use this information too to unload itself at the right time, but that's currently not implemented.
-
Use a more accurate name for the function since it doesn't just check if it is an audio device (which can be detected quite early), but it also checks if the most relevant properties (device info, etc.) have been received. Besides, add the const qualifier to the pointer since it's not going to be modified.
-
Tanu Kaskinen authored
The Device.Connected was only used for tracking whether a device module should be loaded, but that information is already included in the individual profile state properties. The property can therefore be completely ignored without any loss in functionality.
-
Tanu Kaskinen authored
This simplifies some function argument lists.
-
- Nov 20, 2012
-
-
Stream-restore DBus API method argument list is missing last boolean argument apply_immediately, causing assert to fail in AddEntry handling. Signed-off-by: Juho Hämäläinen <jusa@hilvi.org>
-
- Nov 19, 2012
-
-
Arun Raghavan authored
The string created when trying to use XDG_RUNTIME_DIR is freed before it is used in a debug message, and is freed again. https://bugs.freedesktop.org/show_bug.cgi?id=57280
-
Arun Raghavan authored
This makes sure we don't try to plug in a passthrough stream if the final sink/source sample spec doesn't match what we want. In the future, we might want to change rate updates to try a full sample spec update for passthrough streams. https://bugs.freedesktop.org/show_bug.cgi?id=50951
-
Arun Raghavan authored
The could that should have been after the rate update ended up being before, which is incorrect.
-
- Nov 17, 2012
-
-
Arun Raghavan authored
This drops ChangeLog generation from git. It does not make sense to distribute 500 kB of ChangeLog given how easy it is these days to browse history with git. We might replace this with a release-annoucement-esque high-level summary of changes.
-
Arun Raghavan authored
-
- Nov 16, 2012
-
-
Arun Raghavan authored
Since the old UNIX fd IPC mechanism was removed and we rely on the D-Bus based API, this is the oldest version that is known to reliably work.
-
Arun Raghavan authored
Since some devices can be chatty with regards to how often they return from poll(), this adds a PA_UNLIKELY() to all the the rewind_requested checks in our sink modules to make the general case (no rewind was requested) the fast path.
-
Tanu Kaskinen authored
When a rewind is requested on a sink input, the request parameters are stored in the pa_sink_input struct. The parameters are reset during rewind processing, and if the sink decides to ignore the rewind request due to being suspended, stale parameters are left in pa_sink_input. It's particularly problematic if the rewrite_bytes parameter is left at -1, because that will prevent all future rewind processing on that sink input. So, in order to avoid stale parameters, every rewind request needs to be processed, even if the sink is suspended. Reported-by: Uoti Urpala
-
Arun Raghavan authored
We don't need to try a rate update if the desired sample rate is the same as the one the sink or source is already using.
-
David Henningsson authored
...over "Digital Input Source:Analog Input". It makes life a little easier for users of Dell xps m1330. Just an old Ubuntu delta I never upstreamed until now. The patch was originally written by Daniel T Chen <crimsun@ubuntu.com>. BugLink: https://bugs.launchpad.net/bugs/453966 Signed-off-by: David Henningsson <david.henningsson@canonical.com>
-
- Nov 15, 2012
-
-
If the mainloop is just about to enter polling, but m->state is not POLLING yet when some other thread calls pa_mainloop_wakeup(), the mainloop will not be woken up. It's safe to write to the wakeup pipe at any time, so let's just remove the check.
-
The variable is accessed from multiple threads, so it should be atomic.
-
- Nov 14, 2012
-
-
David Henningsson authored
These are sometimes being used in the HDA driver and we should support them. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
-
- Nov 12, 2012
-
-
Arun Raghavan authored
Setting to 0 in the parser causes daemon startup to fail.
-
Sjoerd Simons authored
-
- Nov 09, 2012
-
-
David Henningsson authored
Based on feedback in the bug below (comments 128, 129, 131). BugLink: https://bugs.launchpad.net/bugs/946232 Signed-off-by: David Henningsson <david.henningsson@canonical.com>
-
- Nov 08, 2012
-
-
Previously, if there was a hole in a recording stream, pa_stream_peek() would crash. Holes could be handled silently inside pa_stream_peek() by generating silence (wouldn't work for compressed streams, though) or by skipping any holes. However, I think it's better to let the caller decide how the holes should be handled, so in case of holes, pa_stream_peek() will return NULL data pointer and the length of the hole in the nbytes argument. This change is technically an interface break, because previously the documentation didn't mention the possibility of holes that need special handling. However, since holes caused crashing anyway in the past, it's not a regression if applications keep misbehaving due to not handing holes properly. Some words about when holes can appear in recording streams: I think it would be reasonable behavior if overruns due to the application reading data too slowly would cause holes. Currently that's not the case - overruns will just cause audio to be skipped. But the point is that this might change some day. I'm not sure how holes can occur with the current code, but as the linked bug shows, they can happen. It's most likely due to recording from a monitor source where the thing being monitored has holes in its playback stream. BugLink: http://bugs.launchpad.net/bugs/1058200
-
Arun Raghavan authored
s/pa_latency_info/pa_timing_info
-
- Nov 07, 2012
-
-
Refactor code to fetch avail, delay and timestamp values in a single call to snd_pcm_status(). The information reported is exactly the same as before, however it is extracted in a more atomic manner to improve timer-based scheduling. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
-
- Nov 05, 2012
-
-
Arun Raghavan authored
This reverts commit 15696018. Rethinking this, it makes more sense to not add this to the check framework. This is mostly useful for exposing ALSA driver issues, and it's handy to be able to build this as a standalone executable.
-
Arun Raghavan authored
We don't need to log an error-level message for missing UCM config.
-